Repository navigation
Change residue level MOI calculation to all atom - #442
ioanaapapa wants to merge 7 commits into
Conversation
… terms are expect for small molecules (1 residue); changes to residue rovib are expected for polymers
harryswift01
left a comment
There was a problem hiding this comment.
Hi @ioanaapapa, this looks like great work moving the MOI calculation to use all atoms. I've been working on making the calculations in CodeEntropy reproducible, to remove the flakiness in the PR and regression runs. It turned out to be in the axes calculations, so #440 overlaps with this branch. I did a trial merge locally and the code conflicts are small: the function renames in axes.py (get_vanilla_axes → get_molecule_axes, get_custom_axes → get_bonded_vector_axes, get_custom_principal_axes → get_principal_axes_from_tensor and get_principal_axes → get_principal_axes_from_group), the two places in get_residue_axes and get_residue_axes_from_topology where you call get_vanilla_axes keep your change, only the name differs, and the mocks in three tests. The regression baselines also conflict, since both branches regenerate them. Would it be ok for you to merge main into this branch, resolve those, and regenerate all of the baselines, including the slow ones. Once that's done I think we'll be in a good position to review it properly, and I'm happy to help if you get stuck on the merge.
|
@harryswift01 Thanks, Harry! I'll try to merge main and resolve the conflicts. Will let you know if I have any questions |
Summary
This PR closes #441 and changes the MOI calculation at the residue level to use all atoms masses and positions, rather than heavy atom positions and UA (heavy atom + hydrogens) masses. This corresponds to what we discussed in the CodeEntropy catch up meeting on 8 October 2026.
Changes
Impact
benzene_MOIs.txt
thioredoxin.txt