Repository navigation
Conversation
/proc/diskstats reports partition I/O in both the partition row and the parent disk row, and getHostSystemStats summed both, so Block I/O read ~2x real. Add a shouldIncludeDiskStat filter: virtual devices stay excluded, and a partition row is skipped when its parent disk is present (handles sdX1/vdX1 and nvme0n1p1/mmcblk0p1 naming without dropping whole disks like nvme0n1 that end in a digit). Fixes Dokploy#5385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5385.
Confirmed - /proc/diskstats reports partition I/O in both the partition row and the parent disk row, and getHostSystemStats was summing both, so Block I/O reads ~2x real. This adds a shouldIncludeDiskStat filter: virtual devices stay excluded, and a partition row is skipped when its parent disk is present (handles sdX1/vdX1 and nvme0n1p1/mmcblk0p1 naming without dropping whole disks like nvme0n1 that end in a digit). Tests cover sd/nvme/mmc naming, virtual devices, and the no-parent edge case.
Verification: new vitest suite red against unpatched utils (5/5 fail), 5/5 green with the fix.
The PR appears safe to merge, with no actionable correctness, security, or test-integration issues identified.
Summary