Repository navigation
Add ItemStackTemplate value to packetTest - #1549
Merged
Merged
Conversation
26.1 introduced the ItemStackTemplate type (used by SlotComponent, Particle, SlotDisplay and advancements), and packetTest had no value for it, failing with 'No value for type ItemStackTemplate'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MY5J9XTnWK8ZsJTmxvi7vF
arielvino
added a commit
to arielvino/node-minecraft-protocol
that referenced
this pull request
Oct 25, 2026
Merge upstream PrismarineJS/node-minecraft-protocol master (PrismarineJS#1549) into iongolem (2026-10-25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master's
test (26.1)fails withNo value for type ItemStackTemplate: 26.1 added theItemStackTemplatetype (used bySlotComponent,Particle,SlotDisplayandpacket_advancements), andtest/packetTest.jshad no sample value for it. Every PR that runs 26.1 inherits this failure.This adds a one-line value matching the type's shape (
itemId,itemCount, component counts and empty component arrays).Verified locally with
npx mocha test/packetTest.js -g 26.1v: 228 passing / 1 failing before, 229 passing after.standardis clean.Generated by Claude Code