Repository navigation
AI Slop Cleanup: v1 STAR: move_to_xy_position on Head; no _move_over - #1490
Merged
Merged
Conversation
…e_over` `_move_over` combined a check, a Z move and the X/Y travel for the 96-head's liquid commands. The travel is now `Head.move_to_xy_position(x, y)` (with `_require_iswap_parked`), shared by both heads: iSWAP parked, the arm's pipetting channels up, then X and Y together. Each caller makes its own Z move first. `probe_liquid_height` and `mix` still refuse without tips before anything moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VULgbLpT8fuPc9bpc9sgAN
…_start` and `z_speed` - the head's lowest point is raised to `minimum_traverse_height_start` if below it, as `Pipettes.move_to_xy_positions` raises its channels; the head's safe Z when None - `z_speed` is how fast the head goes up; `mix` passes its descent speed - `probe_liquid_height`, `aspirate`, `dispense` and `mix` no longer move Z themselves first Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is raised Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ttings - X: `x_acceleration_level` (2 at low Y, else 3, when None) and `x_current_limit` - Y: `y_speed`, `y_acceleration`, `y_current_limit`, checked with Y before the head is raised - Z: `z_acceleration` next to `z_speed` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the stop disc The stop disc is read, and the target is the given height plus the tips' overhang only when tips are on; one stop-disc move raises the head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
added a commit
to BioCam/pylabrobot
that referenced
this pull request
Oct 15, 2026
BioCam
added a commit
to BioCam/pylabrobot
that referenced
this pull request
Oct 15, 2026
…-alignment-part2 Part 2 on top of part 1 and current main (PyLabRobot#1489, PyLabRobot#1490): the alignment, the checks before moving and `return_tips`, with the tip commands travelling through `move_to_xy_position`. Part 2's own earlier dispensing-drive and travel code gives way to upstream's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VULgbLpT8fuPc9bpc9sgAN
BioCam
added a commit
to BioCam/pylabrobot
that referenced
this pull request
Oct 16, 2026
BioCam
added a commit
to BioCam/pylabrobot
that referenced
this pull request
Oct 16, 2026
…-alignment-part2 Part 2 on top of part 1 and current main (PyLabRobot#1489, PyLabRobot#1490): the alignment, the checks before moving and `return_tips`, with the tip commands travelling through `move_to_xy_position`. Part 2's own earlier dispensing-drive and travel code gives way to upstream's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The 96-head's liquid commands travelled through
_move_over, a private helper that mixed a tip check, a Z move and the X/Y travel. The 384-head had no X/Y travel at all. And the head's travel did not matchPipettes.move_to_xy_positions: it took no traverse height, could lower a head to it rather than only raise it, fixed its X acceleration, and gave the caller none of the drives' speed, acceleration or current settings.PR Content/Solution
Head.move_to_xy_position(x, y, *, ...)onHead, shared by both heads;_require_iswap_parkedmoves with it and_move_overis goneminimum_traverse_height_startif below it; the arm's pipetting channels go up to their safe Z; then X and Y travel togetherminimum_traverse_height_start=Nonemoves the stop disc to the top of the windowprobe_z_maxfound at setup; a given height only ever raises the head, as onPipettes.move_to_xy_positionsx_acceleration_level,x_current_limit,y_speed,y_acceleration,y_current_limit,z_speed,z_accelerationx_acceleration_level=Noneis 2 at a Y of 200 mm or less, where the head stands furthest out from the X drive, else 3 (was 1 and 3)probe_liquid_height,aspirate,dispenseandmixpass their traverse height instead of moving Z themselves;mixpasses its descent speed asz_speed.probe_liquid_heightandmixrefuse without tips before anything movesA traverse height below where the head already stands no longer brings it down: the head travels where it is.
🤖 Generated with Claude Code