Repository navigation
Test the real XGAP under Xvfb, with coverage - #44
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
===========================================
- Coverage 93.71% 49.78% -43.93%
===========================================
Files 3 28 +25
Lines 175 10302 +10127
Branches 0 558 +558
===========================================
+ Hits 164 5129 +4965
- Misses 11 5083 +5072
- Partials 0 90 +90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tst/testall.g talks to a GAP in package mode without any window, so it can neither open a sheet nor reach the C code. Add tests that run inside the XGAP binary, which CI starts under Xvfb: graphic objects on a sheet, and menu operations on a subgroup lattice, including the "SelectedGroups to GAP" entry. These runs yield coverage data for both the C and the GAP code, so restore the coverage upload. Assisted-by: Claude Code (Fable 5.1)
fingolfin
force-pushed
the
mh/coverage
branch
from
September 20, 2026 14:53
5bc1027 to
3564895
Compare
fingolfin
added this pull request to stack #49
September 20, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tst/testall.gtalks to a GAP in package mode without any window, so it can neither open a sheet nor reach the C code. This addstst-gui/, whose tests run inside the XGAP binary; CI starts it under Xvfb.sheet.tst: graphic objects on a plain sheetlattice.tst: menu operations on a subgroup lattice, including a regression test for SelectedGroups to GAP fails #26run.g: driver. XGAP shows GAP's output in its window and does not pass on its exit status, so results go totst-gui.logandtst-gui.status;--quitonbreakandtimeoutkeep an error from hanging the job.Coverage
The run collects coverage for the GAP code (
--cover) and the C code (gcov;build-pkgalready compiles with--coverage), so the coverage upload is back. Codecov now shows 28 files, 49.78% overall: the 20 GAP files (e.g.lib/ilatgrp.gi,lib/gobject.gi) and the 8 C files (gapgraph.c76%,xgap.c55%,xcmds.c43%,gaptext.c26%,pty.c25%,selfile.c0%).The C files only appeared after rebasing onto #47. With the old build, which compiled in
bin/<arch>, codecov accepted the uploaded.gcovfiles without error but silently left all C files out of the report. An earlier version of this description said the../../src.x11/paths were not the cause; that was wrong, or at best incomplete. Rewriting theSource:line inside the.gcovfiles did not help, but compiling from the top level, which also changes the.gcovfile names from^#^#src.x11#xcmds.c.gcovtosrc.x11#xcmds.c.gcov, did.codecov/projectfails because codecov compares against a stored base of 93.71%, from when only the test driver was measured. It should settle once master has a report from this setup.Assisted-by: Claude Code (Fable 5.1)