Skip to content

ci: bump gradle-wrapper from 9.4.1 to 9.7.1 - #2973

Closed
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/gradle/gradle-wrapper-9.7.1
Closed

dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/gradle/gradle-wrapper-9.7.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 28, 2026

Copy link
Copy Markdown
Contributor

Bumps gradle-wrapper from 9.4.1 to 9.7.1.

Release notes

Sourced from gradle-wrapper's releases.

9.7.1

The Gradle team is excited to announce Gradle 9.7.1.

This is a patch release for 9.7.0. We recommend using 9.7.1 instead of 9.7.0.

Here are the highlights of 9.7.0 release:

  • Isolated Projects graduates to incubating
  • Broader Configuration Cache compatibility
  • Resilient Sync helps you fix broken builds
  • More source locations in problem reports

Read the Release Notes

We would like to thank the following community members for their contributions to this release of Gradle: Adam, Aman Gautam, Aman Kumar, Anton Dubrouski, Aurimas, gbhavya07, Josh Friend, nicklauslittle-gov, Pragati, project516, Qin Mi, Ravi, sk-reddy17, Suvrat Acharya, Yongshun Ye.

Upgrade instructions

Switch your build to use Gradle 9.7.1 by updating your wrapper:

./gradlew :wrapper --gradle-version=9.7.1 && ./gradlew :wrapper

See the Gradle 9.x upgrade guide to learn about deprecations, breaking changes and other considerations when upgrading.

For Java, Groovy, Kotlin and Android compatibility, see the full compatibility notes.

Reporting problems

If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines. If you're not sure you're encountering a bug, please use the forum.

We hope you will build happiness with Gradle, and we look forward to your feedback via Twitter or on GitHub.

9.7.0

The Gradle team is excited to announce Gradle 9.7.0.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 9.4.1 to 9.7.1.
- [Release notes](https://github.com/gradle/gradle/releases)
- [Commits](gradle/gradle@v9.4.1...v9.7.1)

---
updated-dependencies:
- dependency-name: gradle-wrapper
  dependency-version: 9.7.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update java code labels Sep 28, 2026
Comment thread gradle/wrapper/gradle-wrapper.properties

@jaime-jmebot jaime-jmebot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routine wrapper bump — looks correct and low risk: the distribution URL in gradle/wrapper/gradle-wrapper.properties now points at gradle-9.7.1-bin.zip, and 9.7.1 is a patch release on the same 9.x line we already run, so nothing else in the repo needs a version bump.

  • Only observation: the wrapper doesn't pin a distribution checksum yet. Adding one is optional but cheap insurance for build integrity (see the inline note, which comes with a ready-to-commit suggestion).
  • Once CI is green (build + screenshot tests), this should be good to merge.

Co-authored-by: Jaime Bot <jaime@rblb.it>
@riccardobl

Copy link
Copy Markdown
Member

@jaime-jmebot this pr fails CI with Could not get unknown property 'sourceSets'

@jaime-jmebot

Copy link
Copy Markdown
Contributor

Thanks for catching that — good spot, and sorry for the noise from the bot landing on this PR.

A bit of context first: 9.4.1 has been our tested baseline for a while (the 9.5.1 and 9.6.1 bumps were closed without ever being merged), so this is the first wrapper bump that actually gets exercised by CI. The diff only touches the wrapper, so the trigger lives inside Gradle 9.5→9.7, not in our scripts.

That error means a project was asked for sourceSets while it had no java plugin. In our build exactly two projects are set up that way — :jme3-android-examples and :jme3-screenshot-tests:jme3-screenshot-tests-android (they get common-android-app.gradle instead of common.gradle) — and they're still configured on every build, even a plain ./gradlew build on desktop. gradle/jacoco.gradle also applies the standalone jacoco plugin to them. So if AGP or the jacoco plugin starts touching project.sourceSets while configuring those two, the build dies before anything is compiled — which fits the symptom.

Could you paste the failing job's * What went wrong: block (the > Could not get unknown property 'sourceSets' … line plus the Where: line below it) and tell me which job it is? That points straight at the plugin that broke, and it's the one piece I can't see from here.

If it turns out to be a real incompatibility, the fastest way forward is to bisect (9.5.1 → 9.6.1 → 9.7.1) so we know whether a small build-script guard is enough or we should stay on 9.4.1 for the moment. I can reproduce locally and push a fix onto this branch if we go that way.

Small positive: the wrapper checksum is on this branch now and matches the value published by Gradle, so a corrupted download will fail fast instead of being executed.

@riccardobl

Copy link
Copy Markdown
Member

@jaime-jmebot please open a new pr that supersedes this and apply the wrapper upgrade and also the buildscript fix needed to fix the ci error

@jaime-jmebot

Copy link
Copy Markdown
Contributor

Happy to do this, but I want to be straight with you about two things before we go further.

1. I can't open new pull requests. My access here is limited to commenting and reviewing on this PR, and the branch (dependabot/gradle/gradle-wrapper-9.7.1) belongs to Dependabot, so I can't push a fix onto it either. So the practical path is: you open a branch (or a PR from a fork) off master, ping me, and I'll do the wrapper bump + the buildscript fix on it. Then this one can just be closed.

2. I still need one line of the CI log before I write the fix. I asked earlier and we moved past it — no pressure, but it's the difference between a real fix and a guess. The * What went wrong: block plus the Where: line below it:

* What went wrong:
Could not get unknown property 'sourceSets' for object of type org.gradle.api.Project.
> Where:

I'd rather not hand you a buildscript change that just moves the error to the next line.

What I can narrow down from the build scripts

  • Exactly two projects are configured without the java plugin: :jme3-android-examples and :jme3-screenshot-tests:jme3-screenshot-tests-android. The subprojects block in build.gradle gives them common-android-app.gradle instead of common.gradle, so they never get java-library — and therefore never get sourceSets.
  • No CI job actually builds Android. Checkstyle, SpotBugs, Doclint, ScreenshotTests, TestIOSBuild and BuildJMonkey all just run plain ./gradlew tasks. But that Android app project is still configured on every build, so this is a configuration-time failure, not a compile failure.
  • The plugins touching those two projects are therefore the suspects: AGP itself, the third-party io.github.0ffz.github-packages plugin (v1.2.1, used only by the screenshot-tests Android app), or the JaCoCo plugins — gradle/jacoco.gradle applies jacoco to every subproject, including both Android projects, even though neither has anything to instrument.
  • The two sourceSets uses in our own scripts are both safe: mergedJavadoc in build.gradle and javadoc in common.gradle only run in projects that already have the java plugin. I'd rule those out.

If it turns out to be JaCoCo

The fix is small and I'd be comfortable pushing it: stop wiring up coverage for subprojects that have no JVM plugin at all, instead of applying it unconditionally. That keeps the desktop/JVM modules exactly as they are today and just stops poking sourceSets at the two Android projects. If it's AGP or the packages plugin instead, the fix lives in a different place, so it's worth confirming first.

One other option if you'd rather not wait: I can just close this PR and you keep 9.4.1 until we've got the log. Your call — I'd lean towards getting the new branch going and letting CI tell us on the new PR.

@riccardobl

Copy link
Copy Markdown
Member

@jaime-jmebot now you should be able to do that

@jaime-jmebot

Copy link
Copy Markdown
Contributor

Thanks — grabbing that now. Here's the plan for the superseding PR, so you know what you'll get:

  • Wrapper bump 9.4.1 → 9.7.1, same as this PR (plus the distributionSha256Sum pin from my earlier inline note, since we're regenerating the properties file anyway).
  • The buildscript fix, once I've actually reproduced the failure. That's the part I couldn't do from here — the check runs for this branch aren't visible to me, so no log to read. Over in the write phase I can just run ./gradlew locally and get the real * What went wrong: block instead of guessing, then bisect 9.5.1 → 9.6.1 → 9.7.1 to see which release introduced it.
  • My prior is still the two Android projects (:jme3-android-examples, :jme3-screenshot-tests-android), which are configured without the java plugin on every build, with gradle/jacoco.gradle applying the standalone jacoco plugin to them. If the log confirms that, the fix is to only wire up coverage for JVM subprojects — small, and it leaves the desktop modules untouched.

Once that PR is open, this one can be closed — Dependabot will just re-open a fresh one for the same bump if the superseding PR goes stale.

One thing worth flagging either way: 9.4.1 is the version we've actually been building against, since 9.5.1 and 9.6.1 never landed. So this isn't a "patch bump", it's the first real upgrade in a while — if the fix turns out to be more than a couple of lines, I'd rather land 9.5.1 first and follow up, so we get a smaller blast radius if something else surfaces.

@jaime-jmebot

Copy link
Copy Markdown
Contributor

I have opened #2978 to supersede this pull request as requested by @riccardobl.

@jaime-jmebot

jaime-jmebot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

I have opened #2978 (#2978) to supersede this pull request as requested by @riccardobl. Please see #2978 for full implementation details, analysis of the Gradle 9.5 breaking change, and CI results.

@riccardobl riccardobl closed this Sep 28, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/gradle/gradle-wrapper-9.7.1 branch September 28, 2026 16:21
riccardobl added a commit that referenced this pull request Sep 28, 2026
* ci: bump gradle-wrapper from 9.4.1 to 9.7.1

Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 9.4.1 to 9.7.1.
- [Release notes](https://github.com/gradle/gradle/releases)
- [Commits](gradle/gradle@v9.4.1...v9.7.1)

---
updated-dependencies:
- dependency-name: gradle-wrapper
  dependency-version: 9.7.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update gradle/wrapper/gradle-wrapper.properties

Co-authored-by: Jaime Bot <jaime@rblb.it>

* Bump Gradle wrapper to 9.7.1, fix jme3-terrain build script

Supersedes #2973. Gradle 9.5 added DependencyHandler.project(String),
so project(':jme3-core') inside dependencies {} returns a
ProjectDependency with no sourceSets. Resolve the test-output file
collection at the top of the script instead.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Riccardo Balbo <riccardo0blb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants