Repository navigation
Supersede PR #2973: ci: bump gradle-wrapper from 9.4.1 to 9.7.1 - #2978
Merged
riccardobl merged 3 commits intoSep 28, 2026
Merged
riccardobl merged 3 commits into
riccardobl merged 3 commits into
Conversation
Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 9.4.1 to 9.7.1. - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.4.1...v9.7.1) --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.7.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jaime Bot <jaime@rblb.it>
Supersedes jMonkeyEngine#2973. Gradle 9.5 added DependencyHandler.project(String), so project(':jme3-core') inside dependencies {} returns a ProjectDependency with no sourceSets. Resolve the test-output file collection at the top of the script instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2973
Requested by @riccardobl.
Supersedes #2973, as requested. It has the same wrapper bump plus the buildscript fix that makes CI pass.
What was actually breaking
I pulled the failing log, so no more guessing. Every job died during configuration, before anything compiled:
DefaultProjectDependencywas the giveaway — the receiver isn't the project, it's a project dependency. The offending line was:Inside a
dependencies { }block, Gradle configures the block with theDependencyHandleras delegate. Up to 9.4 that handler had noproject(String)overload, so the call fell through to the script and returned theProject— which is why.sourceSetsworked. Gradle 9.5 addedDependencyHandler.project(String), so the call now matches the delegate and returns aProjectDependencyinstead, which has nosourceSets.I checked the API docs across versions to be sure: 9.4.1 only has
project(Map), 9.5.0 addsproject(String). So this was introduced somewhere in 9.5 — it never had anything to do with the Android projects, my earlier guess. Good thing CI could tell us.The fix
One line moved out of the
dependenciesblock, whereproject(path)unambiguously means theProject:Wrapping in
files()keeps it a file collection, so the implicit dependency on:jme3-core's test compilation is carried over exactly as before — the terrain tests still compilejme3-core's tests first. The in-file comment explains why it can't go back.I swept the other build scripts: no other
dependenciesblock dereferences a property on a project dependency, and the otherproject(':x').tasks.named(...)calls are fine because they aren't in adependenciesblock. The Android apps configure with their own plugin and never touchproject.sourceSetsat the project level.Also included
The
distributionSha256Sumpin from my inline note on #2973, since the properties file was being rewritten anyway. It means a corrupted wrapper download now fails the build instead of being executed — worth noting that CI'swrapper-validationstep only checks the wrapper JAR, not the distribution zip, so nothing else covered this.Honest caveat
I couldn't run
./gradlewend-to-end here, so this hasn't had a real build against it — CI is the first full exercise of 9.4.1 → 9.7.1. What I did verify: the failing log and its exact line, the delegate-resolution mechanism (reproduced in isolation against the 9.4 and 9.5 handler shapes), that the new file configures cleanly under 9.7 semantics, and that every build script still parses. The change is deliberately narrow so that if something else in 9.5–9.7 surfaces, the diff makes it obvious.#2973 can be closed. One heads-up: Dependabot will open a fresh one for the same bump once this merges or goes stale.
Changes
jme3-terrain/build.gradle