Skip to content

Replace JetBrains nullability annotation in Spring AOT - #5000

Merged
kubernetes-prow[bot] merged 2 commits into
masterfrom
copilot/remove-jetbrains-annotations
Nov 12, 2026
Merged

Replace JetBrains nullability annotation in Spring AOT#5000
kubernetes-prow[bot] merged 2 commits into
masterfrom
copilot/remove-jetbrains-annotations

Conversation

Copilot AI commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Spring AOT only used JetBrains @NotNull on its bean-factory parameter. Replace it with Spring’s annotation and remove the module’s direct JetBrains dependency.

  • Annotation: Use org.springframework.lang.NonNull on processAheadOfTime.
  • Dependencies: Remove JetBrains annotations from the Spring AOT Maven and Bazel declarations; retain shared dependency management for other repository uses.
processAheadOfTime(@NonNull ConfigurableListableBeanFactory beanFactory)

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 11, 2026
Copilot AI linked an issue Nov 11, 2026 that may be closed by this pull request
Remove JetBrains annotations dependency from Spring AOT module #4997
Closed
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2026
@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2026
Copilot AI changed the title [WIP] Remove JetBrains annotations dependency from Spring AOT module Replace JetBrains nullability annotation in Spring AOT Nov 11, 2026
Copilot AI requested a review from brendandburns November 11, 2026 19:34
@brendandburns
brendandburns marked this pull request as ready for review November 11, 2026 20:31
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 November 11, 2026 20:31
@brendandburns
brendandburns force-pushed the copilot/remove-jetbrains-annotations branch from 2102dd4 to e4301d4 Compare November 12, 2026 00:57
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2026
@brendandburns

brendandburns commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2026
@kubernetes-prow

kubernetes-prow Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 3af85b5 into master Nov 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns
@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Copilot code review Copilot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove JetBrains annotations dependency from Spring AOT module

2 participants

@brendandburns