Skip to content

Replace JetBrains nullability annotation in Spring AOT #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubernetes-prow merged 2 commits into from
Nov 12, 2026
Merged

Replace JetBrains nullability annotation in Spring AOT #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01494c
Initial plan
brendandburns Nov 11, 2026
e4301d4
Use Spring NonNull in Spring AOT processor
brendandburns Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion spring-aot/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ java_library(
"//extended:client-java-extended",
"@maven//:com_google_code_gson_gson",
"@maven//:io_swagger_swagger_annotations",
"@maven//:org_jetbrains_annotations",
"@maven//:org_reflections_reflections",
"@maven//:org_slf4j_slf4j_api",
"@maven//:org_springframework_boot_spring_boot",
Expand Down
7 changes: 0 additions & 7 deletions spring-aot/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>

<!-- JetBrains annotations for NotNull -->
<dependency>
<groupId>org.jetbrains</groupId>
<artifactId>annotations</artifactId>
<version>26.1.0</version>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
4 changes: 2 additions & 2 deletions ...java/io/kubernetes/client/spring/aot/KubernetesBeanFactoryInitializationAotProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jetbrains.annotations.NotNull;
import org.reflections.Reflections;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -30,6 +29,7 @@
import org.springframework.beans.factory.aot.BeanFactoryInitializationAotProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.boot.autoconfigure.AutoConfigurationPackages;
import org.springframework.lang.NonNull;

/**
* GraalVM native images need to know about when you might reflectively work with types at runtime.
Expand All @@ -52,7 +52,7 @@ public class KubernetesBeanFactoryInitializationAotProcessor

@Override
public BeanFactoryInitializationAotContribution processAheadOfTime(
@NotNull ConfigurableListableBeanFactory beanFactory) {
@NonNull ConfigurableListableBeanFactory beanFactory) {
return (generationContext, beanFactoryInitializationCode) -> {
RuntimeHints hints = generationContext.getRuntimeHints();
String[] classNames =
Expand Down
Loading