Skip to content

[2/n] [meta] enforce sorted Cargo.toml dependencies via tombi, add a CI check - #11102

Draft
sunshowers wants to merge 1 commit into
mainfrom
sunshowers/spr/meta-enforce-sorted-cargotoml-dependencies-via-tombi-add-a-ci-check
Draft

sunshowers wants to merge 1 commit into
mainfrom
sunshowers/spr/meta-enforce-sorted-cargotoml-dependencies-via-tombi-add-a-ci-check

Conversation

@sunshowers

@sunshowers sunshowers commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Pared down version of #10815 and #10864. Use tombi for autoformatting Cargo.toml files.

See the comment in .config/tombi.toml for why we're skipping TOML file linting for now.

Depends on:

Created using spr 1.3.6-beta.1
@sunshowers
sunshowers marked this pull request as draft August 18, 2026 21:41
@sunshowers sunshowers changed the title [meta] enforce sorted Cargo.toml dependencies via tombi, add a CI check [2/n] [meta] enforce sorted Cargo.toml dependencies via tombi, add a CI check Aug 18, 2026
sunshowers added a commit that referenced this pull request Oct 5, 2026
…_with_formatting_args bugs (#11103)

Preparatory cleanups for #11102:

* Merge `clickhouse_confirm_binary_works` and
`cockroach_confirm_binary_works` into a single `confirm_binary_works`.
* Don't discard stderr if it isn't valid UTF-8.
* Include stdout in the failure message.
* Add a `read_version_file` helper.
* Fix a bug where we had `.context("Failed to read version from
{versions_path}")` which wouldn't interpolate `versions_path`.
* Turns out the non-interpolating bug is covered by the
`literal_string_with_formatting_args` clippy lint -- turn that on.
* This found a bunch of other instances, most of which were genuine
(though a few were false positives) -- fix and exclude them as
appropriate.
* Reject empty version files as a programmer error.
* Include the file path in the `get_values_from_file` missing-keys
error.
* In flake.nix, make `findSha` throw with an actionable message when a
checksum entry is missing, instead of silently returning "".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant