Repository navigation
[2/n] [meta] enforce sorted Cargo.toml dependencies via tombi, add a CI check - #11102
Draft
sunshowers wants to merge 1 commit into
Draft
sunshowers wants to merge 1 commit into
sunshowers wants to merge 1 commit into
Conversation
Created using spr 1.3.6-beta.1
This was referenced Aug 18, 2026
sunshowers
marked this pull request as draft
August 18, 2026 21:41
sunshowers
added a commit
that referenced
this pull request
Oct 5, 2026
…_with_formatting_args bugs (#11103) Preparatory cleanups for #11102: * Merge `clickhouse_confirm_binary_works` and `cockroach_confirm_binary_works` into a single `confirm_binary_works`. * Don't discard stderr if it isn't valid UTF-8. * Include stdout in the failure message. * Add a `read_version_file` helper. * Fix a bug where we had `.context("Failed to read version from {versions_path}")` which wouldn't interpolate `versions_path`. * Turns out the non-interpolating bug is covered by the `literal_string_with_formatting_args` clippy lint -- turn that on. * This found a bunch of other instances, most of which were genuine (though a few were false positives) -- fix and exclude them as appropriate. * Reject empty version files as a programmer error. * Include the file path in the `get_values_from_file` missing-keys error. * In flake.nix, make `findSha` throw with an actionable message when a checksum entry is missing, instead of silently returning "".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pared down version of #10815 and #10864. Use tombi for autoformatting Cargo.toml files.
See the comment in
.config/tombi.tomlfor why we're skipping TOML file linting for now.Depends on: