Repository navigation
fix(sei-global-wallet): clear the sharp, Vite, and stream-json drift - #356
Conversation
Advisories published since October 5 turned the nightly consumer smoke red. GHSA-wq5f-xc86-pv6w covers sharp below 0.35.5, a librsvg memory bug in its prebuilt binaries, and reaches the wallet-only npm consumer through @dynamic-labs/iconic's exact sharp@0.35.0 pin. The verifier's override set and all three README blocks move to 0.35.5, and the README's Sharp note covers both Sharp advisories. GHSA-hqr4-qq8f-hg3x and GHSA-mjw6-4jj6-33hc cover stream-json below 3.6.0, which jayson requires as CommonJS on the optional AA path. 3.6.0 is still ESM-only, so like GHSA-528h-pc64-c93x they can't be overridden, and both are accepted for the npm and Bun AA consumers. Neither is reachable from a wallet: stream-json 1.9.1 has no JSONC parser, and jayson only runs Assembler in its TCP and TLS transports, while @solana/web3.js imports jayson/lib/client/browser. The verifier's browser consumer moves from vite 8.2.2 to 8.2.4 for six Vite and bundled launch-editor advisories. Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryLow Risk Overview
Optional AA path: two additional Verifier tooling: the browser consumer’s Patch changeset only; no published dependency or peer range changes. Reviewed by Cursor Bugbot for commit f3232f8. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 81 81
Lines 5652 5652
=======================================
Hits 5529 5529
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This PR raises the documented and verifier sharp override to 0.35.5, bumps the verifier's vite to 8.2.4, and waives two new stream-json advisories on the optional AA path only. The wallet-only npm consumer is still held to a clean audit, the README and script stay in sync, and a patch changeset is included. I found nothing blocking.
Findings: 0 blocking | 3 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The Cursor review file (
cursor-review.md) was empty, so that pass produced no output. Codex found no material issues. - I couldn't check the advisory IDs and dates from the diff: GHSA-wq5f-xc86-pv6w / CVE-2026-96889, GHSA-hqr4-qq8f-hg3x and GHSA-mjw6-4jj6-33hc. The same goes for the claim that
stream-json@1.9.1ships no JSONC parser and thatjayson/lib/client/browsernever loadsAssembler. Reviewers should confirm them against the GitHub Advisory Database before the waiver ships in the published README. - The waiver scope is correct: the new IDs go only into
acceptedNpmAdvisoriesandacceptedBunAdvisories, which apply to the full AA consumers. The wallet-only consumer stays strictly audit-clean, and the existing 'now audits clean' check will flag the waivers once upstream fixes land. Consider tracking a follow-up to drop thestream-jsonwaivers oncejaysonor@solana/web3.jsmove off the CommonJSstream-json@1.x.
Fixes the scheduled Sei Global Wallet Consumer Smoke failure, which has been red since October 6. Three sets of advisories landed after #354:
GHSA-wq5f-xc86-pv6w(high, October 6) coverssharpbelow0.35.5: a memory bug in the bundled librsvg (CVE-2026-96889) that can lead to RCE on glibc-based Linux when decoding untrusted SVG. Dynamic's@dynamic-labs/iconicstill pinssharp@0.35.0exactly, so the wallet-only npm consumer, which must audit clean, reportedsharpplus the eight packages above it.GHSA-hqr4-qq8f-hg3xandGHSA-mjw6-4jj6-33hc(moderate, October 5) coverstream-jsonbelow3.6.0, whichjaysonrequires as CommonJS on the optional AA path.launch-editoradvisories (October 20 and 21) cover thevite@8.2.2the verifier's browser consumer builds with.Changes
Move the
sharpoverride from0.35.4to0.35.5in the verifier's override set and all three README blocks, and rewrite the README's Sharp note to cover both Sharp advisories.Accept the two
stream-jsonadvisories for the npm and Bun AA consumers.3.6.0, the only fixed release, is still ESM-only under the movedsrc/layout, so an override breaksjayson'srequirethe same way it does forGHSA-528h-pc64-c93x. Neither is reachable from a wallet:GHSA-hqr4-qq8f-hg3xis in the JSONC parser and verifier, andstream-json@1.9.1ships no JSONC parser.GHSA-mjw6-4jj6-33hcis inAssembler, whichjaysonruns only in its TCP and TLS transports.@solana/web3.js1.98.1 imports onlyjayson/lib/client/browser, which loadsuuidandgenerateRequestand nothing else.The README's waiver section now lists all three
stream-jsonadvisories.Bump the verifier's
vitefrom8.2.2to8.2.4, the patched release on the same minor.Add a
@sei-js/sei-global-walletpatch changeset, since the override and waiver guidance ships in the package README.Verification
bun run test:sei-global-wallet-release(full run, without the fast-check flag) passes locally on Bun 1.3.14, the versionmainpins. The wallet-only npm consumer audits clean, the full npm consumer reports only the three waivedstream-jsonadvisories, and the Bun AA consumer reports only its waivedbn.js,stream-json, andwsadvisories.bun run checkandbun run test:scripts(48 tests) pass.No published dependency or peer range changes.