Repository navigation
[HyperElastic] Fix inverted Stable Neo-Hookean scene and add regression coverage - #6377
Open
lililii124 wants to merge 1 commit into
Open
lililii124 wants to merge 1 commit into
lililii124 wants to merge 1 commit into
Conversation
…on coverage Signed-off-by: yz <3318283120@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6220.
The inverted Stable Neo-Hookean example has conflicting topologies and develops non-finite states. This separates the initial inverted grid from the rest topology, computes mass on the tetrahedral rest mesh, and reduces the time step to 1e-5. Geometry, material parameters, total mass and fixed nodes are unchanged.
Adds a 100-step state regression and four material tests for negative-J stress and tangent consistency, including an analytical reflection case.
Validation used a Windows Release build in double precision. The 28 HyperElastic tests completed without failures. A 5,000-step simulation remained finite, with no fixed-node drift or inverted tetrahedra at the end. Repeating the state comparison reported zero error; the absolute-J and missing-force-field controls produced the expected test failures.
Scene validation used a native C++ harness with SOFA's simulation engine and official WriteState/CompareState visitors. The runSofa CLI, upstream Regression_test executable and cross-platform CI were not exercised.
Companion reference data: sofa-framework/Regression#142. The regression entry requires these files.
AI assistance was used for implementation, tests and validation. Requested label:
pr: AI-aided.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if