Skip to content

[HyperElastic] Fix inverted Stable Neo-Hookean scene and add regression coverage - #6377

Open
lililii124 wants to merge 1 commit into
sofa-framework:masterfrom
lililii124:fix/6220-stable-neohookean-regression
Open

lililii124 wants to merge 1 commit into
sofa-framework:masterfrom
lililii124:fix/6220-stable-neohookean-regression

Conversation

@lililii124

Copy link
Copy Markdown

Fixes #6220.

The inverted Stable Neo-Hookean example has conflicting topologies and develops non-finite states. This separates the initial inverted grid from the rest topology, computes mass on the tetrahedral rest mesh, and reduces the time step to 1e-5. Geometry, material parameters, total mass and fixed nodes are unchanged.

Adds a 100-step state regression and four material tests for negative-J stress and tangent consistency, including an analytical reflection case.

Validation used a Windows Release build in double precision. The 28 HyperElastic tests completed without failures. A 5,000-step simulation remained finite, with no fixed-node drift or inverted tetrahedra at the end. Repeating the state comparison reported zero error; the absolute-J and missing-force-field controls produced the expected test failures.

Scene validation used a native C++ harness with SOFA's simulation engine and official WriteState/CompareState visitors. The runSofa CLI, upstream Regression_test executable and cross-platform CI were not exercised.

Companion reference data: sofa-framework/Regression#142. The regression entry requires these files.

AI assistance was used for implementation, tests and validation. Requested label: pr: AI-aided.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

…on coverage

Signed-off-by: yz <3318283120@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing regression on Stable NeoHookean

1 participant