Repository navigation
build(deps): refactor CMake files for finding GTest - #140
Merged
ingomueller-net merged 1 commit intoApr 9, 2026
Merged
Conversation
ingomueller-net
force-pushed
the
cmake-revamp-gtest
branch
from
March 26, 2026 19:12
620c701 to
cc1bf66
Compare
ingomueller-net
marked this pull request as ready for review
March 26, 2026 19:21
ingomueller-net
force-pushed
the
cmake-revamp-gtest
branch
2 times, most recently
from
March 30, 2026 18:36
7e33912 to
2b3c664
Compare
ingomueller-net
marked this pull request as draft
March 31, 2026 07:42
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
cmake-revamp-gtest
branch
from
March 31, 2026 08:04
f803207 to
aae781d
Compare
ingomueller-net
marked this pull request as ready for review
March 31, 2026 08:04
This was referenced Mar 31, 2026
EpsilonPrime
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is currently stacked on top of #138.This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by #138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice.