Skip to content

chore: update paykit to rc70 - #1435

Merged
ovitrif merged 1 commit into
masterfrom
codex/paykit-rc70
Oct 7, 2026
Merged

ovitrif merged 1 commit into
masterfrom
codex/paykit-rc70

Conversation

@ben-kaufman

Copy link
Copy Markdown
Contributor

This PR upgrades the Android Paykit dependency to rc70 and documents the shared-state deployment requirement.

Follows merged #1401; targets master.

Description

  • Pins com.synonym:paykit-android to 0.1.0-rc70 in gradle/libs.versions.toml; GitHub Packages resolution and the Maven-local exclusion remain unchanged.
  • Documents in docs/pubky.md that shared-state deployments require Homeserver 0.15 or newer on every serving instance. Paykit does not upgrade or verify the homeserver; pending markers and the five-minute uncertain-write cooldown remain required.

No consumer runtime, test, or UI changes.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Device journeys and performance were not tested; no performance improvement is claimed.

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

  • ran remote-artifact verification — downloaded the rc70 AAR from GitHub Packages, verified its hashes against remote module metadata, and confirmed rc70 on devDebugUnitTestRuntimeClasspath with dependencyInsight.
  • ran forced Kotlin recompilation and unit tests with --rerun --no-build-cache -Pkotlin.incremental=false — all 3,587 tests passed with no failures, errors, or skips; all 190 source compiler warnings match the baseline.
  • ran complete SARIF and Gradle Problems comparison despite ignoreFailures — all 19 baseline Detekt warnings, including one formatting finding, and the single Gradle plugin deprecation are unchanged; no new findings.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 3e243d0 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High risk] Updates a core payment processing dependency.

The PR appears safe to merge; no actionable issue was found.

What we checked:

  • Local Paykit cannot override the pin: The repository settings explicitly exclude com.synonym:paykit-android from Maven-local resolution.

Summary

Updates com.synonym:paykit-android from 0.1.0-rc69 to 0.1.0-rc70.

  • Documents that shared-state deployments need Homeserver 0.15 or newer on every serving instance.
  • Clarifies that the dependency does not upgrade or check the homeserver, and recovery precautions remain required.
  • No actionable issues were found. Builds and tests were not run during this review.

Reviews (1) · Last reviewed commit: "chore: update paykit to rc70" · Reviewed by Greptile

@ben-kaufman
ben-kaufman requested a review from ovitrif October 7, 2026 17:51

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve

Review: diff 2 files.
The iOS pair PR synonymdev/bitkit-ios#886 updates to the same rc70 release and documents the same Homeserver requirement and recovery limits.

QA:
No tests ran because this PR declares no user-visible change and lists journeys and manual tests as N/A.


Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif added this to the 2.6.0 milestone Oct 7, 2026
@ovitrif
ovitrif enabled auto-merge October 7, 2026 18:03
@ovitrif
ovitrif merged commit 484e6dd into master Oct 7, 2026
23 checks passed
@ovitrif
ovitrif deleted the codex/paykit-rc70 branch October 7, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants