Skip to content

chore: update Paykit to rc70 - #886

Merged
ovitrif merged 1 commit into
masterfrom
codex/paykit-rc70
Oct 7, 2026
Merged

ovitrif merged 1 commit into
masterfrom
codex/paykit-rc70

Conversation

@ben-kaufman

Copy link
Copy Markdown
Contributor

This PR updates Bitkit to Paykit 0.1.0-rc70.

Follow-up to the merged #856, targeting master.

Description

  • Updates Paykit for its Pubky 0.15 and pubky-noise rc13 integration.
  • Documents the requirement for Homeserver 0.15 or newer on every serving instance; the SDK neither upgrades the homeserver nor verifies its version.

Pending markers and the five-minute uncertain-write cooldown remain in place; not all uncertain-publication cases are eliminated.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

  • ran 732 focused Paykit, Pubky, contact, and authorization tests against the published rc70 XCFramework: all pass.
  • ran a baseline compiler/format/translation diagnostic comparison: no introduced findings. The 69 source compiler warnings, 18 formatting findings, and 1,862 translation warnings also occur on the parent revision.
  • ran release-artifact verification: the resolved rc70 commit and downloaded XCFramework checksum match the published release; generated Swift APIs are unchanged.

Simulator build passes. Physical-device, live-payment, homeserver-rollout, and performance behavior have not been validated by this dependency update.

@ben-kaufman
ben-kaufman requested a review from piotr-iohk October 7, 2026 17:37
@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Updates a core cryptographic and payment library dependency.

The PR appears safe to merge; no actionable defects were found.

Summary

Updates Paykit from 0.1.0-rc69 to 0.1.0-rc70.

  • Updates the exact version and resolved commit together.
  • Documents the Homeserver 0.15 requirement for every shared-state serving instance.
  • Clarifies that pending markers and the five-minute cooldown remain.
  • No actionable issues were found.

Reviews (1) · Last reviewed commit: "chore: update Paykit to rc70" · Reviewed by Greptile

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve

Review: diff 3 files.
Android master still uses Paykit rc69, and synonymdev/bitkit-android#1435 makes the same rc70 update and documents the same Homeserver 0.15 requirement and retained recovery behavior. Neither update changes the shared wire or storage formats.

QA:
I ran no tests because the description reports no user-visible change and requests no manual test or journey, only automated checks the author already ran.


Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif
ovitrif enabled auto-merge October 7, 2026 18:33
@ovitrif
ovitrif merged commit a231b82 into master Oct 7, 2026
19 checks passed
@ovitrif
ovitrif deleted the codex/paykit-rc70 branch October 7, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants