Repository navigation
test: compare attribute names without relying on iteration order - #6707
Merged
Merged
Conversation
Element.getAttributeNames() does not specify an order. Flow 25.4 stores element attributes in shared key sets, so the names now come back in insertion order instead of hash order and the list comparison fails.
peholmst
marked this pull request as ready for review
November 19, 2026 11:03
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
peholmst
pushed a commit
that referenced
this pull request
Nov 19, 2026
## Summary Pull requests never ran the Java tests under `src/test`. The Maven workflow ran `mvn compile`, which builds only the main sources. A failing snippet test could therefore merge with every check green, and the first build to run it was the production docs deployment. That build then failed until the test was fixed (see #6707). ## What changed - The Maven Compile workflow now runs `mvn test --batch-mode --no-transfer-progress` instead of `mvn compile`. A broken snippet test, for example after a Vaadin version bump, now fails on the PR. - The workflow and job names stay the same, so any required-check configuration that refers to them keeps working. - `CLAUDE.md`, `CONVENTIONS.md`, `guidelines/repository.md` and the code review prompt now tell contributors to run `mvn test` locally instead of `mvn compile`. ## Test summary - `mvn test` passes locally on current `main`. It runs the existing snippet tests in a few seconds. Working on behalf of Petter --------- Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
AttributeTestsnippet test fails with Vaadin 25.4.0-alpha7 and later. It comparedElement.getAttributeNames()against an ordered list, but that method doesn't specify an order. This failure blocks the main branch build.What changed
HashMaporder and now come back in the key set's order, which is usually insertion order.Test summary
Working on behalf of Petter