Skip to content

ci: run the Java tests on pull requests - #6708

Merged
peholmst merged 2 commits into
mainfrom
ci/run-java-tests
Nov 19, 2026
Merged

peholmst merged 2 commits into
mainfrom
ci/run-java-tests

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pull requests never ran the Java tests under src/test. The Maven workflow ran mvn compile, which builds only the main sources. A failing snippet test could therefore merge with every check green, and the first build to run it was the production docs deployment. That build then failed until the test was fixed (see #6707).

What changed

  • The Maven Compile workflow now runs mvn test --batch-mode --no-transfer-progress instead of mvn compile. A broken snippet test, for example after a Vaadin version bump, now fails on the PR.
  • The workflow and job names stay the same, so any required-check configuration that refers to them keeps working.
  • CLAUDE.md, CONVENTIONS.md, guidelines/repository.md and the code review prompt now tell contributors to run mvn test locally instead of mvn compile.

Test summary

  • mvn test passes locally on current main. It runs the existing snippet tests in a few seconds.

Working on behalf of Petter

The Maven workflow only compiled the main sources, so a failing snippet
test under src/test went unnoticed until the deployment build ran it.
Also hide Maven transfer progress in the CI log.
@peholmst
peholmst marked this pull request as ready for review November 19, 2026 11:17

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@github-actions

Copy link
Copy Markdown
Contributor

Preview Deployment

This PR has been deployed for preview.

URL: https://docs-preview-pr-6708.fly.dev

No documentation page changes detected.

Built from 5382d7a

@peholmst
peholmst merged commit d678278 into main Nov 19, 2026
17 checks passed
@peholmst
peholmst deleted the ci/run-java-tests branch November 19, 2026 11:25
@peholmst peholmst added the target/v25.3 Automatically cherry-pick to the v25.3 branch label Nov 19, 2026
@vaadin-bot

Copy link
Copy Markdown
Contributor

Hi @totally-not-ai[bot] and @peholmst, when i performed cherry-pick to this commit to v25.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d678278
error: could not apply d678278... ci: run the Java tests on pull requests (#6708)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need to pick manually v25.3 target/v25.3 Automatically cherry-pick to the v25.3 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants