Repository navigation
ci: run the Java tests on pull requests - #6708
Conversation
The Maven workflow only compiled the main sources, so a failing snippet test under src/test went unnoticed until the deployment build ran it.
Also hide Maven transfer progress in the CI log.
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-6708.fly.dev No documentation page changes detected. Built from 5382d7a |
|
Hi @totally-not-ai[bot] and @peholmst, when i performed cherry-pick to this commit to v25.3, i have encountered the following issue. Can you take a look and pick it manually? |
Summary
Pull requests never ran the Java tests under
src/test. The Maven workflow ranmvn compile, which builds only the main sources. A failing snippet test could therefore merge with every check green, and the first build to run it was the production docs deployment. That build then failed until the test was fixed (see #6707).What changed
mvn test --batch-mode --no-transfer-progressinstead ofmvn compile. A broken snippet test, for example after a Vaadin version bump, now fails on the PR.CLAUDE.md,CONVENTIONS.md,guidelines/repository.mdand the code review prompt now tell contributors to runmvn testlocally instead ofmvn compile.Test summary
mvn testpasses locally on currentmain. It runs the existing snippet tests in a few seconds.Working on behalf of Petter