Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
These checks of a pull request already report their findings:

- Vale (`lint`): the writing style of the lines added under `articles/`.
- Maven Compile and Format Check: the Java examples compile and follow the Java formatting conventions.
- Maven Compile and Format Check: the Java examples compile, their tests pass, and they follow the Java formatting conventions.
- Check Redirects: a moved or removed page leaves a redirect behind, and every redirect resolves.
- Check Versions: the version attributes in `articles/_vaadin-version.adoc` match `pom.xml`.
- Check Feature Flags: every feature flag of Flow and Flow Components is documented.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maven-compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ jobs:
java-version: '21'
distribution: 'temurin'
cache: 'maven'
- name: Compile with Maven
run: mvn compile
- name: Compile and run tests with Maven
run: mvn test --batch-mode --no-transfer-progress
4 changes: 2 additions & 2 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ npm run dspublisher:build
# Run ESLint on frontend code
npm run lint

# Compile the Java examples
mvn compile
# Compile the Java examples and run their tests
mvn test

# Format the Java examples, must be run before committing a Java change
mvn spotless:apply
Expand Down
2 changes: 1 addition & 1 deletion CONVENTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ Comment arguments whose meaning is not obvious from the call, such as `null`
passed for a filter.

Run `mvn spotless:apply` after changing Java examples and `npm run lint` after
changing TypeScript examples. `mvn compile` must pass.
changing TypeScript examples. `mvn test` must pass.

## Component Pages

Expand Down
2 changes: 1 addition & 1 deletion guidelines/repository.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ one.
| Workflow | What it checks | Run locally |
| ------------------- | ------------------------------------------------------------------------------ | --------------------------------------------- |
| lint (Vale) | Writing style of `articles/`, reported as review annotations. | `vale articles/path/to/page.adoc` |
| Maven Compile | The Java examples compile. | `mvn compile` |
| Maven Compile | The Java examples compile and their tests under `src/test` pass. | `mvn test` |
| Format Check | The Java examples are formatted with the Vaadin Java conventions. | `mvn spotless:apply` |
| Check Redirects | A moved or removed page leaves a redirect behind, and every redirect resolves. | `npm run check-redirects` |
| Check Versions | `articles/_vaadin-version.adoc` matches `pom.xml`; fixed automatically on the PR branch. | `npm run sync-versions -- --fix` |
Expand Down
Loading